src/factory.cc - Issue 1185313002: --print-scopes should ignore native code, even ones parsed lazily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1185313002: --print-scopes should ignore native code, even ones parsed lazily. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@debugger

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 444f6e312e9a0e84f304f0f455ef54d155dc2784..3827fee5a5b62bb1a342b57ac408fa870f97f416 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2274,8 +2274,6 @@ Handle<DebugInfo> Factory::NewDebugInfo(Handle<SharedFunctionInfo> shared) {

// Get the original code of the function.

Handle<Code> code(shared->code());

- DCHECK(code->has_debug_break_slots());

adamk 2015/06/16 16:04:28 Is this a stray from some other patch?

// Create a copy of the code before allocating the debug info object to avoid

// allocation while setting up the debug info object.

Handle<Code> original_code(*Factory::CopyCode(code));

« no previous file with comments | « no previous file | src/scopes.cc » ('j') | no next file with comments »