Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1185313002: --print-scopes should ignore native code, even ones parsed lazily. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@debugger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

--print-scopes should ignore native code, even ones parsed lazily. R=adamk@chromium.org Committed: https://crrev.com/789c0601fd5611751e409104abc9a2c200ac2580 Cr-Commit-Position: refs/heads/master@{#29093}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove stray edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/scopes.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 6 months ago (2015-06-16 10:07:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185313002/1
5 years, 6 months ago (2015-06-16 10:07:42 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1362)
5 years, 6 months ago (2015-06-16 10:08:44 UTC) #5
adamk
lgtm % possible stray code https://codereview.chromium.org/1185313002/diff/1/src/factory.cc File src/factory.cc (left): https://codereview.chromium.org/1185313002/diff/1/src/factory.cc#oldcode2277 src/factory.cc:2277: DCHECK(code->has_debug_break_slots()); Is this a ...
5 years, 6 months ago (2015-06-16 16:04:28 UTC) #6
Yang
On 2015/06/16 16:04:28, adamk wrote: > lgtm % possible stray code > > https://codereview.chromium.org/1185313002/diff/1/src/factory.cc > ...
5 years, 6 months ago (2015-06-17 14:08:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185313002/20001
5 years, 6 months ago (2015-06-17 14:08:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 15:21:27 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 15:21:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/789c0601fd5611751e409104abc9a2c200ac2580
Cr-Commit-Position: refs/heads/master@{#29093}

Powered by Google App Engine
This is Rietveld 408576698