Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1185303004: Allow skia_win.cpp to be compiled in CONSOLE or GUI mode. (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vb
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow skia_win.cpp to be compiled in CONSOLE or GUI mode. Make visualbench and SampleApp build in CONSOLE mode so that we can see stdout. I verified that by undoing the gyp modifications both tools will build as GUI. Committed: https://skia.googlesource.com/skia/+/48297f72fb852bed08d4af4de23366dfae39c245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -148 lines) Patch
M gyp/SampleApp.gyp View 2 chunks +3 lines, -5 lines 0 comments Download
M gyp/visualbench.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/views/win/skia_win.cpp View 4 chunks +72 lines, -141 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 6 months ago (2015-06-16 14:59:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185303004/1
5 years, 6 months ago (2015-06-16 19:15:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-16 19:15:35 UTC) #5
joshualitt
On 2015/06/16 19:15:35, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 6 months ago (2015-06-16 19:18:32 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 19:21:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/48297f72fb852bed08d4af4de23366dfae39c245

Powered by Google App Engine
This is Rietveld 408576698