Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 1185303003: Improve seeding of AddressSpaceRandomization randomness. (Closed)

Created:
4 years, 10 months ago by Chris Evans
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve seeding of AddressSpaceRandomization randomness. - Mix in a bit of time as well as pid. (On Linux, pids can be identical between processes because of namespacing.) - We use raw calls to fetch the time, to keep PartitionAlloc standalone and not depend on a platform callback. Furthermore, we're deep inside an allocator at this point and the platform callbacks are not simple and might re-enter a memory allocator which is a no-no. For consistency, bring the process id related calls inline. - Also add a TODO to improve the randomization range on Win8.1+. BUG=499465 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M Source/wtf/AddressSpaceRandomization.cpp View 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Chris Evans
4 years, 10 months ago (2015-06-16 07:44:18 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-16 09:35:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185303003/1
4 years, 10 months ago (2015-06-16 17:16:39 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 17:20:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197182

Powered by Google App Engine
This is Rietveld 408576698