Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1185303002: Quick disable of NPAPI browser tests that are failing on win8_chromium_gn bot. (Closed)

Created:
5 years, 6 months ago by jam
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick disable of NPAPI browser tests that are failing on win8_chromium_gn bot. The NPAPI test plugin isn't built in GN, so the bots fail if the plugin didn't happen to be already there from gyp. More thorough removal is in https://codereview.chromium.org/1182303010 BUG=493212, 497423 TBR=dpranke Committed: https://crrev.com/3def35df3c338780318019dfca2b8d054f93a1d0 Cr-Commit-Position: refs/heads/master@{#334597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/content_tests.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jam
5 years, 6 months ago (2015-06-16 14:09:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185303002/1
5 years, 6 months ago (2015-06-16 14:10:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 14:13:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3def35df3c338780318019dfca2b8d054f93a1d0 Cr-Commit-Position: refs/heads/master@{#334597}
5 years, 6 months ago (2015-06-16 14:15:01 UTC) #6
Dirk Pranke
I'm confused by the description in this CL; AFAIK, we're not running browser_tests on any ...
5 years, 6 months ago (2015-06-16 16:03:41 UTC) #7
jam
On 2015/06/16 16:03:41, Dirk Pranke wrote: > I'm confused by the description in this CL; ...
5 years, 6 months ago (2015-06-16 16:21:42 UTC) #8
Dirk Pranke
5 years, 6 months ago (2015-06-16 17:22:12 UTC) #9
Message was sent while issue was closed.
ok, lgtm.

Powered by Google App Engine
This is Rietveld 408576698