Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: chrome/browser/chromeos/login/login_utils.cc

Issue 11853012: Improved test coverage of login_utils_browsertest.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/login_utils.cc
diff --git a/chrome/browser/chromeos/login/login_utils.cc b/chrome/browser/chromeos/login/login_utils.cc
index 705e77373018501e4c15fad03614450d92fda214..c8d02045708ee4a801da489667a5d66253d6d569 100644
--- a/chrome/browser/chromeos/login/login_utils.cc
+++ b/chrome/browser/chromeos/login/login_utils.cc
@@ -232,7 +232,6 @@ class LoginUtilsImpl
const GaiaAuthConsumer::ClientLoginResult& credentials) OVERRIDE;
virtual void StopBackgroundFetchers() OVERRIDE;
virtual void InitRlzDelayed(Profile* user_profile) OVERRIDE;
- virtual void CompleteProfileCreate(Profile* user_profile) OVERRIDE;
// OAuth1TokenFetcher::Delegate overrides.
void OnOAuth1AccessTokenAvailable(const std::string& token,
@@ -306,6 +305,10 @@ class LoginUtilsImpl
void OnProfileCreated(Profile* profile,
Profile::CreateStatus status);
+ // Callback to resume profile creation after transferring auth data from
+ // the authentication profile.
+ void CompleteProfileCreate(Profile* user_profile);
+
// Finalized profile preparation.
void FinalizePrepareProfile(Profile* user_profile);
@@ -318,7 +321,7 @@ class LoginUtilsImpl
std::string password_;
bool pending_requests_;
bool using_oauth_;
- // True if the authenrication profile's cookie jar should contain
+ // True if the authentication profile's cookie jar should contain
// authentication cookies from the authentication extension log in flow.
bool has_web_auth_cookies_;
// Has to be scoped_refptr, see comment for CreateAuthenticator(...).
@@ -522,9 +525,6 @@ void LoginUtilsImpl::OnProfileCreated(
Profile::CreateStatus status) {
CHECK(user_profile);
- if (delegate_)
- delegate_->OnProfileCreated(user_profile);
-
switch (status) {
case Profile::CREATE_STATUS_INITIALIZED:
break;

Powered by Google App Engine
This is Rietveld 408576698