Issue 1185283004: fix analyzer warnings in stocks app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1185283004: fix analyzer warnings in stocks app (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

fix analyzer warnings in stocks app R=ianh@google.com TBR=hixie Committed: https://chromium.googlesource.com/external/mojo/+/38cf7236330685fbc57e79aa6ddace2cc21cf9bf

Patch Set 2 : hixix cr feedback #

Patch Set 3 : rebase #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/examples/stocks2/lib/stock_home.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_settings.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/app/view.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1185283004/diff/1/sky/examples/stocks/lib/stock_app.dart File sky/examples/stocks/lib/stock_app.dart (left): https://codereview.chromium.org/1185283004/diff/1/sky/examples/stocks/lib/stock_app.dart#oldcode5 sky/examples/stocks/lib/stock_app.dart:5: import 'package:sky/framework/components/tool_bar.dart'; did you mean to change this ...

5 years, 6 months ago (2015-06-17 21:17:12 UTC) #2

jackson

Committed patchset #3 (id:40001) manually as 38cf7236330685fbc57e79aa6ddace2cc21cf9bf (presubmit successful).

5 years, 6 months ago (2015-06-17 21:19:56 UTC) #3