Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: sky/tools/packager/vm.cc

Issue 1185233002: Update Dart dependency and patch dart_controller to account for non-backwards compatible API update (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/script/dart_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/packager/vm.cc
diff --git a/sky/tools/packager/vm.cc b/sky/tools/packager/vm.cc
index 7472198dff37aa9fb41a5cdb9d68edd9b4fefb86..5e45eb8cb21fea7b0b71d51bf2b89637af0bb662 100644
--- a/sky/tools/packager/vm.cc
+++ b/sky/tools/packager/vm.cc
@@ -18,21 +18,17 @@ void InitDartVM() {
const char** argv = nullptr;
CHECK(Dart_SetVMFlags(argc, argv));
- CHECK(Dart_Initialize(blink::kDartVmIsolateSnapshotBuffer,
- nullptr, // Isolate created callback.
- nullptr, // Isolate interrupt callback.
- nullptr, // Unhandled exception callback.
- nullptr, // Isolate shutdown callback.
- // File IO callbacks.
- nullptr, nullptr, nullptr, nullptr, nullptr));
+ CHECK(Dart_Initialize(blink::kDartVmIsolateSnapshotBuffer, nullptr, nullptr,
+ nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
+ nullptr));
}
Dart_Isolate CreateDartIsolate() {
CHECK(blink::kDartIsolateSnapshotBuffer);
char* error = nullptr;
- Dart_Isolate isolate =
- Dart_CreateIsolate("http://example.com", "main",
- blink::kDartIsolateSnapshotBuffer, nullptr, &error);
+ Dart_Isolate isolate = Dart_CreateIsolate("http://example.com", "main",
+ blink::kDartIsolateSnapshotBuffer,
+ nullptr, nullptr, &error);
CHECK(isolate) << error;
CHECK(!LogIfError(Dart_SetLibraryTagHandler(HandleLibraryTag)));
« no previous file with comments | « sky/engine/core/script/dart_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698