Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1536)

Unified Diff: mojo/dart/embedder/dart_controller.cc

Issue 1185233002: Update Dart dependency and patch dart_controller to account for non-backwards compatible API update (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/dart_controller.h ('k') | sky/engine/core/script/dart_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/embedder/dart_controller.cc
diff --git a/mojo/dart/embedder/dart_controller.cc b/mojo/dart/embedder/dart_controller.cc
index 52b9644a51e4981556914e5999635cbfc6444d0d..d90844cce961ac7ad5cc8cc1681bd129d683fe49 100644
--- a/mojo/dart/embedder/dart_controller.cc
+++ b/mojo/dart/embedder/dart_controller.cc
@@ -260,8 +260,9 @@ Dart_Isolate DartController::CreateIsolateHelper(
script,
script_uri,
package_root);
- Dart_Isolate isolate = Dart_CreateIsolate(
- script_uri.c_str(), "main", isolate_snapshot_buffer, isolate_data, error);
+ Dart_Isolate isolate =
+ Dart_CreateIsolate(script_uri.c_str(), "main", isolate_snapshot_buffer,
+ nullptr, isolate_data, error);
if (isolate == nullptr) {
delete isolate_data;
return nullptr;
@@ -352,6 +353,7 @@ Dart_Isolate DartController::CreateIsolateHelper(
Dart_Isolate DartController::IsolateCreateCallback(const char* script_uri,
const char* main,
const char* package_root,
+ Dart_IsolateFlags* flags,
void* callback_data,
char** error) {
IsolateData* parent_isolate_data =
« no previous file with comments | « mojo/dart/embedder/dart_controller.h ('k') | sky/engine/core/script/dart_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698