Issue 1185233002: Update Dart dependency and patch dart_controller to account for non-backwards compatible API update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1185233002: Update Dart dependency and patch dart_controller to account for non-backwards compatible API update (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Chinmay

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update Dart dependency and patch dart_controller to account for non-backwards compatible API update Patch originally by chinmaygarde. R=chinmaygarde@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e4abb857f20c9bf6cb9cc0b52e9fdb7688e17bfb

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -22 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/dart/embedder/dart_controller.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/dart/embedder/dart_controller.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	3 chunks	+8 lines, -9 lines	0 comments	Download
M	sky/tools/packager/vm.cc	View	1 chunk	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 6 months ago (2015-06-16 01:34:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e4abb857f20c9bf6cb9cc0b52e9fdb7688e17bfb (presubmit successful).

Expand Messages | Collapse Messages