Issue 11852022: Make profile shortcuts more sane when using --user-data-dir=.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11852022: Make profile shortcuts more sane when using --user-data-dir=. (Closed)

Created:
7 years, 11 months ago by Alexei Svitkine (slow)

Modified:
7 years, 11 months ago

Reviewers:
sail

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make profile shortcuts more sane when using --user-data-dir=. With this CL, Chrome will add a --user-data-dir argument to profile shortcuts when started with a custom --user-data-dir and will not touch profile shortcuts with a non-matching --user-data-dir. BUG=162021 TEST=New unit tests and manual testing starting Chrome with different --user-data-dir values.

Patch Set 1 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+278 lines, -36 lines)			Patch
M	chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc	View	6 chunks	+148 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/profile_shortcut_manager_win.h	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_shortcut_manager_win.cc	View	10 chunks	+115 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

(Codereview decided to send this out with a Re: because of a patch upload that ...

7 years, 11 months ago (2013-01-24 21:07:57 UTC) #3

Alexei Svitkine (slow)

7 years, 11 months ago (2013-01-24 23:48:53 UTC) #4

Closing in favor of: https://codereview.chromium.org/12036097/

Expand Messages | Collapse Messages