Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3305)

Unified Diff: chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h

Issue 1185183008: New Task Manager - Phase 1.3.2.B: Implement Tab Contents Task Providing (Prerender) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gavinp's and thestig's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h
diff --git a/chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h b/chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h
index 62ac3cff62b7bee0c126dd6c04c1f2bee859bca9..da4a3150a00dc85337cbad478daa968206840dc5 100644
--- a/chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h
+++ b/chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.h
@@ -33,6 +33,12 @@ class WebContentsTagsManager {
void SetProvider(WebContentsTaskProvider* provider);
void ClearProvider();
+ // This is called by WebContentsTags::ClearTag(). This is needed for Tags
+ // whose destruction does not correspond to the destruction of their
+ // WebContents. In this case the provider (if any) must be manually cleared,
+ // or else the corresponding task for the |tag| will continue to exist.
+ void ClearFromProvider(const WebContentsTag* tag);
+
const std::set<WebContentsTag*>& tracked_tags() const {
return tracked_tags_;
}

Powered by Google App Engine
This is Rietveld 408576698