chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h - Issue 1185183008: New Task Manager - Phase 1.3.2.B: Implement Tab Contents Task Providing (Prerender)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h

Issue 1185183008: New Task Manager - Phase 1.3.2.B: Implement Tab Contents Task Providing (Prerender) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gn compile Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/providers/web_contents/prerender_task.cc ('K') | « chrome/browser/task_management/providers/web_contents/web_contents_tags_manager.cc ('k') | chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc » ('j') | chrome/chrome_browser.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h

diff --git a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h

index 0104cac5395be1ddff1d159baa7d336242f39112..519ebc66471a246d3b619514e562f2799653c9d4 100644

--- a/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h

+++ b/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h

@@ -29,7 +29,10 @@ class WebContentsTaskProvider : public TaskProvider {

// This will be called every time we're notified that a new |WebContentsTag|

// has been created.

- void OnWebContentsTagCreated(WebContentsTag* tag);

+ void OnWebContentsTagCreated(const WebContentsTag* tag);

+ // Called to manually remove |tag|'s corresponding Task from the provider.

gavinp 2015/06/23 17:09:17 Nit: (optional) not sure what "Called to" or "from

afakhry 2015/06/23 19:02:47 Done.

+ void OnWebContentsTagRemoved(const WebContentsTag* tag);

// task_management::TaskProvider:

Task* GetTaskOfUrlRequest(int origin_pid,