Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1185173002: Really basic Switch implementation in Sky. Could definitely use some polish (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Really basic Switch implementation in Sky. Could definitely use some polish R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/b830a797367af07e6d9987b875d2f29a390ef82b

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback from abarth, mpcomplete #

Patch Set 3 : renaming #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -111 lines) Patch
M sky/sdk/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 2 1 chunk +60 lines, -111 lines 0 comments Download
A sky/sdk/lib/widgets/switch.dart View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A sky/sdk/lib/widgets/toggleable.dart View 1 2 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jackson
5 years, 6 months ago (2015-06-15 18:15:19 UTC) #1
abarth-chromium
LGTM w/ extracted base class. https://codereview.chromium.org/1185173002/diff/1/sky/sdk/lib/widgets/checkbox.dart File sky/sdk/lib/widgets/checkbox.dart (right): https://codereview.chromium.org/1185173002/diff/1/sky/sdk/lib/widgets/checkbox.dart#newcode168 sky/sdk/lib/widgets/checkbox.dart:168: void _customPaintCallback(sky.Canvas canvas, Size ...
5 years, 6 months ago (2015-06-15 18:19:12 UTC) #2
Matt Perry
https://codereview.chromium.org/1185173002/diff/1/sky/sdk/lib/widgets/checkbox.dart File sky/sdk/lib/widgets/checkbox.dart (right): https://codereview.chromium.org/1185173002/diff/1/sky/sdk/lib/widgets/checkbox.dart#newcode88 sky/sdk/lib/widgets/checkbox.dart:88: [0.0, 1.0] FYI, [0, 1] is the default, so ...
5 years, 6 months ago (2015-06-15 18:22:10 UTC) #4
jackson
5 years, 6 months ago (2015-06-15 19:53:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b830a797367af07e6d9987b875d2f29a390ef82b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698