Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1185163003: lut_inverse_interp16: interpolate degenerate zeros in TRC curves (Closed)

Created:
5 years, 6 months ago by Noel Gordon
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

lut_inverse_interp16: interpolate degenerate zeros in TRC curves Degenerate TRC have runs of 0's / 1's from the left / right edge of the TRC curve (a curve we want to invert, to be able to use a color profile as a monitor profile). The inverse TRC of degenerate curves is not well-defined in the run of 0's area (infinite slope). Some monitor calibration software in the field produce 0 runs, thus degenerate TRC, and QCMS setting the inverse of the run to 0's area to 0 causes a color cast (burn) effect on web images corrected with the associated color profile: issue 492379. Fix that by interpolating the (imaginary) inverse in the 0 run area instead of clamping the inverse to 0. Add more assert conditions to the curve inversion algorithm and also check for an inverted binary search range (these two changes from the related Mozilla bug). CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel BUG=458024 Committed: https://crrev.com/9c5cf06617232b00842383ff001c49fe058fc6b4 Cr-Commit-Position: refs/heads/master@{#334996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185163003/1
5 years, 6 months ago (2015-06-16 15:50:42 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 17:05:29 UTC) #4
Noel Gordon
5 years, 6 months ago (2015-06-17 04:59:41 UTC) #6
Mike Lawther (Google)
On 2015/06/17 04:59:41, noel gordon wrote: I can't access https://bugzil.la/1132467 (permission denied), but if this ...
5 years, 6 months ago (2015-06-17 17:08:46 UTC) #7
Ken Russell (switch to Gerrit)
lgtm too.
5 years, 6 months ago (2015-06-17 17:12:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185163003/1
5 years, 6 months ago (2015-06-18 03:26:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 05:35:04 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 05:35:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c5cf06617232b00842383ff001c49fe058fc6b4
Cr-Commit-Position: refs/heads/master@{#334996}

Powered by Google App Engine
This is Rietveld 408576698