Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1185143002: MIPS: Remove unsafe EmitLoadRegister usage in AddI/SubI for constant right operand. (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove unsafe EmitLoadRegister usage in AddI/SubI for constant right operand. TEST=test/mjsunit/regress/regress-500176 BUG=chromium:500176 LOG=N Committed: https://crrev.com/b7d8cb4a513d201be2f8ff316843217c6b952ceb Cr-Commit-Position: refs/heads/master@{#29030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M src/mips/lithium-codegen-mips.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-500176.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dusmil.imgtec
5 years, 6 months ago (2015-06-15 17:18:50 UTC) #2
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-15 17:28:09 UTC) #3
paul.l...
LGTM. (MIPS64 will be fixed in separate CL.)
5 years, 6 months ago (2015-06-15 17:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185143002/1
5 years, 6 months ago (2015-06-15 17:33:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 17:58:34 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 17:58:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7d8cb4a513d201be2f8ff316843217c6b952ceb
Cr-Commit-Position: refs/heads/master@{#29030}

Powered by Google App Engine
This is Rietveld 408576698