ipc/sync_socket_unittest.cc - Issue 1185133006: IPC: Make ChannelReader inherit from SupportsAttachmentBrokering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/sync_socket_unittest.cc

Issue 1185133006: IPC: Make ChannelReader inherit from SupportsAttachmentBrokering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/sync_socket_unittest.cc

diff --git a/ipc/sync_socket_unittest.cc b/ipc/sync_socket_unittest.cc

index 82ab0cd0992af7721f2e3037e0aca191d9649017..0172c2f298266feb8124ce4a79504225e2bed8eb 100644

--- a/ipc/sync_socket_unittest.cc

+++ b/ipc/sync_socket_unittest.cc

@@ -110,8 +110,8 @@ MULTIPROCESS_IPC_TEST_CLIENT_MAIN(SyncSocketServerClient) {

base::MessageLoopForIO main_message_loop;

SyncSocketServerListener listener;

scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateClient(

- IPCTestBase::GetChannelName("SyncSocketServerClient"),

- &listener));

+ IPCTestBase::GetChannelName("SyncSocketServerClient"), &listener,

+ nullptr));

EXPECT_TRUE(channel->Connect());

listener.Init(channel.get());

base::MessageLoop::current()->Run();

« no previous file with comments | « ipc/mojo/ipc_mojo_perftest.cc ('k') | no next file » | no next file with comments »