ipc/mojo/ipc_mojo_bootstrap_unittest.cc - Issue 1185133006: IPC: Make ChannelReader inherit from SupportsAttachmentBrokering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/mojo/ipc_mojo_bootstrap_unittest.cc

Issue 1185133006: IPC: Make ChannelReader inherit from SupportsAttachmentBrokering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/mojo/ipc_mojo_bootstrap_unittest.cc

diff --git a/ipc/mojo/ipc_mojo_bootstrap_unittest.cc b/ipc/mojo/ipc_mojo_bootstrap_unittest.cc

index fbe0fa89589393c23049bf8e83c98b2540b2e6eb..65d216f82119da5d0db020e6f3db274bc463a7e7 100644

--- a/ipc/mojo/ipc_mojo_bootstrap_unittest.cc

+++ b/ipc/mojo/ipc_mojo_bootstrap_unittest.cc

@@ -47,7 +47,7 @@ TEST_F(IPCMojoBootstrapTest, Connect) {

TestingDelegate delegate;

scoped_ptr<IPC::MojoBootstrap> bootstrap = IPC::MojoBootstrap::Create(

- GetTestChannelHandle(), IPC::Channel::MODE_SERVER, &delegate);

+ GetTestChannelHandle(), IPC::Channel::MODE_SERVER, &delegate, nullptr);

ASSERT_TRUE(bootstrap->Connect());

#if defined(OS_POSIX)

@@ -71,7 +71,8 @@ MULTIPROCESS_IPC_TEST_CLIENT_MAIN(IPCMojoBootstrapTestClient) {

scoped_ptr<IPC::MojoBootstrap> bootstrap = IPC::MojoBootstrap::Create(

IPCTestBase::GetChannelName("IPCMojoBootstrapTestClient"),

IPC::Channel::MODE_CLIENT,

- &delegate);

+ &delegate,

+ nullptr);

bootstrap->Connect();

« no previous file with comments | « ipc/mojo/ipc_mojo_bootstrap.cc ('k') | ipc/mojo/ipc_mojo_perftest.cc » ('j') | no next file with comments »