Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ipc/ipc_channel_nacl.h

Issue 1185133006: IPC: Make ChannelReader inherit from SupportsAttachmentBrokering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from tsepez. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_nacl.h
diff --git a/ipc/ipc_channel_nacl.h b/ipc/ipc_channel_nacl.h
index f0649b2602228a8670b91bff3e3870fc2fb08a16..82ef6edc9d1601f8da5b1a1948573dbafe33912d 100644
--- a/ipc/ipc_channel_nacl.h
+++ b/ipc/ipc_channel_nacl.h
@@ -35,9 +35,11 @@ class ChannelNacl : public Channel,
public internal::ChannelReader {
public:
// Mirror methods of Channel, see ipc_channel.h for description.
+ // |broker| must outlive the newly created object.
ChannelNacl(const IPC::ChannelHandle& channel_handle,
Mode mode,
- Listener* listener);
+ Listener* listener,
+ AttachmentBroker* broker);
~ChannelNacl() override;
// Channel implementation.
@@ -46,6 +48,7 @@ class ChannelNacl : public Channel,
bool Connect() override;
void Close() override;
bool Send(Message* message) override;
+ AttachmentBroker* GetAttachmentBroker() override;
// Posted to the main thread by ReaderThreadRunner.
void DidRecvMsg(scoped_ptr<MessageContents> contents);
@@ -114,6 +117,9 @@ class ChannelNacl : public Channel,
base::WeakPtrFactory<ChannelNacl> weak_ptr_factory_;
+ // |broker_| must outlive this instance.
+ AttachmentBroker* broker_;
+
DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl);
};
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698