Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1185133004: Revert of Build: Don't pass /GL to Clang on Windows (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build: Don't pass /GL to Clang on Windows (patchset #3 id:40001 of https://codereview.chromium.org/1186743002/) Reason for revert: Broke some official builds (http://crbug.com/500393). Will roll clang forward instead. Original issue's description: > Build: Don't pass /GL to Clang on Windows > > Windows Clang's support for LTO isn't ready to take on Chrome yet. > > BUG=82385 > R=thakis@chromium.org > TBR=scottmg > > Committed: https://chromium.googlesource.com/chromium/src/+/4e76e7926ee51bdfdd635437920f455ae6444912 TBR=scottmg@chromium.org,hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=82385 Committed: https://crrev.com/7ec6a579b7e47f84b384b98b6f04ee65beb55758 Cr-Commit-Position: refs/heads/master@{#334419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M build/common.gypi View 1 chunk +1 line, -12 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Build: Don't pass /GL to Clang on Windows
5 years, 6 months ago (2015-06-15 18:24:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185133004/1
5 years, 6 months ago (2015-06-15 18:24:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 18:27:05 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 18:27:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ec6a579b7e47f84b384b98b6f04ee65beb55758
Cr-Commit-Position: refs/heads/master@{#334419}

Powered by Google App Engine
This is Rietveld 408576698