Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1185043005: Sync worker interfaces with the HTML spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, vivekg_samsung, falken, vivekg, Inactive, kinuko+worker_chromium.org, horo+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync worker interfaces with the HTML spec Also include ApplicationCache because of the SharedWorker connection. There are no changes to the generated code other than order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -18 lines) Patch
M Source/core/loader/appcache/ApplicationCache.idl View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerConsole.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.idl View 1 chunk +12 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerLocation.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerNavigator.idl View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185043005/1
5 years, 6 months ago (2015-06-14 20:54:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-14 22:13:05 UTC) #4
philipj_slow
PTAL
5 years, 6 months ago (2015-06-15 07:59:15 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-15 08:39:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185043005/1
5 years, 6 months ago (2015-06-15 08:48:18 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 08:52:13 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197103

Powered by Google App Engine
This is Rietveld 408576698