Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1184953006: Record autoplay disabled by sandbox flags. (Closed)

Created:
4 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 10 months ago
Reviewers:
whywhat, philipj_slow, fs
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Record autoplay disabled by sandbox flags. It's a very easy thing to record and it will help us find out if that actually makes a difference. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197358

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mlamouri (slow - plz ping)
4 years, 10 months ago (2015-06-17 15:36:09 UTC) #2
philipj_slow
lgtm
4 years, 10 months ago (2015-06-17 21:28:47 UTC) #3
fs
https://codereview.chromium.org/1184953006/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1184953006/diff/1/Source/core/html/HTMLMediaElement.cpp#newcode265 Source/core/html/HTMLMediaElement.cpp:265: AutoplayDisableddBySandbox = 5, Drive-by nit: Disabledd
4 years, 10 months ago (2015-06-18 08:18:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184953006/20001
4 years, 10 months ago (2015-06-18 10:25:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67207)
4 years, 10 months ago (2015-06-18 12:51:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184953006/20001
4 years, 10 months ago (2015-06-18 14:10:53 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 15:01:36 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197358

Powered by Google App Engine
This is Rietveld 408576698