Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: build/config/win/BUILD.gn

Issue 1184953004: Revert of Revert of Sync Windows build flags between GYP and GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/internal/release_impl_official.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/win/visual_studio_version.gni") 5 import("//build/config/win/visual_studio_version.gni")
6 6
7 # Compiler setup for the Windows SDK. Applied to all targets. 7 # Compiler setup for the Windows SDK. Applied to all targets.
8 config("sdk") { 8 config("sdk") {
9 # The include path is the stuff returned by the script. 9 # The include path is the stuff returned by the script.
10 #include_dirs = msvc_config[0] TODO(brettw) make this work. 10 #include_dirs = msvc_config[0] TODO(brettw) make this work.
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 } 96 }
97 97
98 # Subsystem -------------------------------------------------------------------- 98 # Subsystem --------------------------------------------------------------------
99 99
100 # This is appended to the subsystem to specify a minimum version. 100 # This is appended to the subsystem to specify a minimum version.
101 if (current_cpu == "x64") { 101 if (current_cpu == "x64") {
102 # The number after the comma is the minimum required OS version. 102 # The number after the comma is the minimum required OS version.
103 # 5.02 = Windows Server 2003. 103 # 5.02 = Windows Server 2003.
104 subsystem_version_suffix = ",5.02" 104 subsystem_version_suffix = ",5.02"
105 } else { 105 } else {
106 # Don't specify a min version on x86. 106 # 5.01 = Windows XP.
107 subsystem_version_suffix = "" 107 subsystem_version_suffix = ",5.01"
108 } 108 }
109 109
110 config("console") { 110 config("console") {
111 ldflags = [ "/SUBSYSTEM:CONSOLE$subsystem_version_suffix" ] 111 ldflags = [ "/SUBSYSTEM:CONSOLE$subsystem_version_suffix" ]
112 } 112 }
113 config("windowed") { 113 config("windowed") {
114 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ] 114 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ]
115 } 115 }
116 116
117 # Incremental linking ---------------------------------------------------------- 117 # Incremental linking ----------------------------------------------------------
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 172
173 # Nominmax -------------------------------------------------------------------- 173 # Nominmax --------------------------------------------------------------------
174 174
175 # Some third party code defines NOMINMAX before including windows.h, which 175 # Some third party code defines NOMINMAX before including windows.h, which
176 # then causes warnings when it's been previously defined on the command line. 176 # then causes warnings when it's been previously defined on the command line.
177 # For such targets, this config can be removed. 177 # For such targets, this config can be removed.
178 178
179 config("nominmax") { 179 config("nominmax") {
180 defines = [ "NOMINMAX" ] 180 defines = [ "NOMINMAX" ]
181 } 181 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/internal/release_impl_official.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698