Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1184923005: ServiceWorker: Add layout test for ready promise resolve after shift-reload. (Closed)

Created:
4 years, 10 months ago by xiang
Modified:
4 years, 10 months ago
Reviewers:
*falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Add layout test for ready promise resolve after shift-reload. Test for CL: https://codereview.chromium.org/1181573010 BUG=462529 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197880

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/chromium/force-refresh-ready.html View 1 2 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
xiang
PTAL, thanks!
4 years, 10 months ago (2015-06-17 07:41:36 UTC) #1
falken
How about a test for force+refresh frame, then register() a SW? https://codereview.chromium.org/1184923005/diff/1/LayoutTests/http/tests/serviceworker/chromium/force-refresh-ready.html File LayoutTests/http/tests/serviceworker/chromium/force-refresh-ready.html (right): ...
4 years, 10 months ago (2015-06-17 15:10:55 UTC) #3
xiang
On 2015/06/17 15:10:55, falken wrote: > How about a test for force+refresh frame, then register() ...
4 years, 10 months ago (2015-06-19 07:45:24 UTC) #4
falken
lgtm I think it belongs in chromium/ mostly since it's testing a chromium-implementation bug rather ...
4 years, 10 months ago (2015-06-24 02:28:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184923005/40001
4 years, 10 months ago (2015-06-26 01:37:49 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 03:04:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197880

Powered by Google App Engine
This is Rietveld 408576698