Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(5)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: src/ports/SkFontMgr_default_gdi.cpp
Issue
1184923002
:
Refactor SkFontHost_linux into SkFontMgr_custom. (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Don't export embedded.
Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
gyp/ports.gyp
include/ports/SkFontMgr_custom.h
src/ports/SkFontHost_linux.cpp
src/ports/SkFontMgr_custom.cpp
src/ports/SkFontMgr_custom_directory_factory.cpp
src/ports/SkFontMgr_custom_embedded_factory.cpp
src/ports/SkFontMgr_default_dw.cpp
src/ports/SkFontMgr_default_gdi.cpp
src/ports/SkFontMgr_win_dw_factory.cpp
src/ports/SkFontMgr_win_gdi_factory.cpp
View unified diff
|
Download patch
« src/ports/SkFontMgr_custom_embedded_factory.cpp
('K') |
« src/ports/SkFontMgr_default_dw.cpp
('k') |
src/ports/SkFontMgr_win_dw_factory.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
#include "SkFontMgr.h"
2
#include "SkTypeface_win.h"
3
4
SkFontMgr* SkFontMgr::Factory() {
5
return SkFontMgr_New_GDI();
6
}
OLD
NEW
« src/ports/SkFontMgr_custom_embedded_factory.cpp
('K') |
« src/ports/SkFontMgr_default_dw.cpp
('k') |
src/ports/SkFontMgr_win_dw_factory.cpp »
('j') |
no next file with comments »
Issue 1184923002: Refactor SkFontHost_linux into SkFontMgr_custom. (Closed)
Created 5 years, 6 months ago by bungeman-skia
Modified 5 years, 6 months ago
Reviewers: reed1
Base URL: https://skia.googlesource.com/skia.git@master
Comments: 4
This is Rietveld
408576698
Chromium Code Reviews
Issue 1184923002:
Refactor SkFontHost_linux into SkFontMgr_custom. (Closed)
Base URL: https://skia.googlesource.com/skia.git@master