Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1184913004: Revert of android: Introduce a ui::PlatformWindow implementation for android. (Closed)

Created:
5 years, 6 months ago by skobes
Modified:
5 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Introduce a ui::PlatformWindow implementation for android. (patchset #5 id:120001 of https://codereview.chromium.org/1180573004/) Reason for revert: Breaks Win GN bots: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/2751 e:\b\build\slave\win_x64_gn\build\src\components\view_manager\native_viewport\platform_viewport_common.cc(64) : error C3861: 'platform_window_reset': identifier not found e:\b\build\slave\win_x64_gn\build\src\components\view_manager\native_viewport\platform_viewport_common.cc(64) : error C2664: 'ui::WinWindow::WinWindow(const ui::WinWindow &)' : cannot convert argument 1 from 'native_viewport::PlatformViewportCommon *const ' to 'const ui::WinWindow &' Reason: cannot convert from 'native_viewport::PlatformViewportCommon *const ' to 'const ui::WinWindow' No constructor could take the source type, or constructor overload resolution was ambiguous Original issue's description: > android: Introduce a ui::PlatformWindow implementation for android. > > This change introduces a ui::PlatformWindow implementation for android, and uses > that from view_manager. The implementation of PlatformWindowAndroid is copied over > from PlatformViewportAndroid. The various PlatformViewport implementations are > merged into a single PlatformViewportCommon implementation, that uses the common > ui::PlaformWindow abstraction for managing the windows. > > BUG=487881 > > Committed: https://crrev.com/870d6cf7d409b5e7dae82c98bfaeaa5137a652d9 > Cr-Commit-Position: refs/heads/master@{#334262} TBR=ben@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487881 Committed: https://crrev.com/707589fabd6b34ba22bf9e3299f603511fd21f48 Cr-Commit-Position: refs/heads/master@{#334281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+851 lines, -751 lines) Patch
M components/view_manager/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M components/view_manager/native_viewport/BUILD.gn View 2 chunks +19 lines, -2 lines 0 comments Download
A components/view_manager/native_viewport/android/src/org/chromium/mojo/PlatformViewportAndroid.java View 1 chunk +184 lines, -0 lines 0 comments Download
A components/view_manager/native_viewport/platform_viewport_android.h View 1 chunk +87 lines, -0 lines 0 comments Download
A components/view_manager/native_viewport/platform_viewport_android.cc View 1 chunk +217 lines, -0 lines 0 comments Download
D components/view_manager/native_viewport/platform_viewport_common.cc View 1 chunk +0 lines, -188 lines 0 comments Download
A components/view_manager/native_viewport/platform_viewport_win.cc View 1 chunk +148 lines, -0 lines 0 comments Download
A components/view_manager/native_viewport/platform_viewport_x11.cc View 1 chunk +173 lines, -0 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/library_loader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/platform_window/BUILD.gn View 2 chunks +0 lines, -19 lines 0 comments Download
D ui/platform_window/android/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/platform_window/android/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java View 1 chunk +0 lines, -184 lines 0 comments Download
D ui/platform_window/android/platform_window_android.h View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/platform_window/android/platform_window_android.cc View 1 chunk +0 lines, -216 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
skobes
Created Revert of android: Introduce a ui::PlatformWindow implementation for android.
5 years, 6 months ago (2015-06-12 23:39:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184913004/1
5 years, 6 months ago (2015-06-12 23:40:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 23:42:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 23:43:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/707589fabd6b34ba22bf9e3299f603511fd21f48
Cr-Commit-Position: refs/heads/master@{#334281}

Powered by Google App Engine
This is Rietveld 408576698