components/autofill/content/renderer/autofill_agent.h - Issue 1184913002: [Password Manager] Suppress UI when password generation is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1184913002: [Password Manager] Suppress UI when password generation is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_test_utils.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.h

diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h

index c75d5d6f443a51555e923adf712f5de57a76ed2a..c71f31d4bbcd22ee47cbe119e593ecbbbb7d06ac 100644

--- a/components/autofill/content/renderer/autofill_agent.h

+++ b/components/autofill/content/renderer/autofill_agent.h

@@ -266,6 +266,12 @@ class AutofillAgent : public content::RenderFrameObserver,

// messages to close the Autofill popup when it can't possibly be showing.

bool is_popup_possibly_visible_;

+ // If the generation popup is possibly visible. This is tracked to prevent

+ // generation UI from displaying at the same time as password manager UI.

+ // This is needed because generation is shown on field focus vs. field click

+ // for the password manager. TODO(gcasto): Have both UIs show on focus.

+ bool is_generation_popup_possibly_visible_;

base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(AutofillAgent);