[Password Manager] Suppress UI when password generation is active

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 248 matching lines @@
   // Whether or not to ignore text changes.  Useful for when we're committing
   // a composition when we are defocusing the WebView and we don't want to
   // trigger an autofill popup to show.
   bool ignore_text_changes_;
 
   // Whether the Autofill popup is possibly visible.  This is tracked as a
   // performance improvement, so that the IPC channel isn't flooded with
   // messages to close the Autofill popup when it can't possibly be showing.
   bool is_popup_possibly_visible_;
 
+  // If the generation popup is possibly visible. This is tracked to prevent
+  // generation UI from displaying at the same time as password manager UI.
+  // This is needed because generation is shown on field focus vs. field click
+  // for the password manager. TODO(gcasto): Have both UIs show on focus.

[Ilya Sherman, 2015/06/16 02:24:09]

Long-term, should there be a combined UI?  Or are we sure that the generation
popup should always trump the password autofill popup?

[Garrett Casto, 2015/06/16 06:15:05]

Really only one of these should be active at any time. If the password field is
for a new password, then we should only show generation, if it's for a current
password we should only show the password management UI. At the moment there are
going to be cases where both trigger because heuristics aren't perfect, but it's
quite rare since we generally don't show the password manager UI when the
password field is focused. 

With increased support for change password forms this conflict may start
happening more often. It's possible that we will need some way to disambiguate, 
we'll just have to see how often it happens.

[Ilya Sherman, 2015/06/16 19:49:23]

Should we record some metrics to verify whether this is indeed common or rare?

[Garrett Casto, 2015/06/17 19:48:10]

I added something in the latest patch. Even if this ends up showing a large
amount of conflicts, I'm not totally sure what we would do about it since we
don't know for certain which is correct, but in all cases I know of now
generation is the right UI if they are in conflict.

+  bool is_generation_popup_possibly_visible_;
+
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_