[Password Manager] Suppress UI when password generation is active

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
@@ skipping 20 matching lines @@
 
 class PasswordGenerationAgentTest : public ChromeRenderViewTest {
  public:
   PasswordGenerationAgentTest() {}
 
   void TearDown() override {
     LoadHTML("");
     ChromeRenderViewTest::TearDown();
   }
 
-  void ExpectPasswordGenerationAvailable(const char* element_id,
-                                         bool available) {
-    WebDocument document = GetMainFrame()->document();
-    WebElement element =
-        document.getElementById(WebString::fromUTF8(element_id));
-    ASSERT_FALSE(element.isNull());
-    ExecuteJavaScript(
-        base::StringPrintf("document.getElementById('%s').focus();",
-                           element_id).c_str());
-    if (available) {
-      ASSERT_EQ(1u, password_generation_->messages().size());
-      EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
-                password_generation_->messages()[0]->type());
-    } else {
-      EXPECT_EQ(0u, password_generation_->messages().size());
-    }
-    password_generation_->clear_messages();
-  }
-
   void LoadHTMLWithUserGesture(const char* html) {
     LoadHTML(html);
 
     // Enable show-ime event when element is focused by indicating that a user
     // gesture has been processed since load.
     EXPECT_TRUE(SimulateElementClick("dummy"));
   }
 
+  void FocusField(const char* element_id) {
+    WebDocument document = GetMainFrame()->document();
+    blink::WebElement element =
+        document.getElementById(blink::WebString::fromUTF8(element_id));
+    ASSERT_FALSE(element.isNull());
+    ExecuteJavaScript(
+        base::StringPrintf("document.getElementById('%s').focus();",
+                           element_id).c_str());
+  }
+
+  void ExpectGenerationAvailable(const char* element_id,
+                                 bool available) {
+    FocusField(element_id);
+    ExpectPasswordGenerationAvailable(password_generation_,
+                                      available);
+  }
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgentTest);
 };
 
 const char kSigninFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'password'/> "
     "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
@@ skipping 94 matching lines @@
     "    firstOnChangeCalled = true;"
     "  };"
     "  document.getElementById('second_password').onchange = function() {"
     "    secondOnChangeCalled = true;"
     "  };"
     "</script>";
 
 TEST_F(PasswordGenerationAgentTest, DetectionTest) {
   // Don't shown the icon for non account creation forms.
   LoadHTMLWithUserGesture(kSigninFormHTML);
-  ExpectPasswordGenerationAvailable("password", false);
+  ExpectGenerationAvailable("password", false);
 
   // We don't show the decoration yet because the feature isn't enabled.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 
   // Pretend like We have received message indicating site is not blacklisted,
   // and we have received message indicating the form is classified as
   // ACCOUNT_CREATION_FORM form Autofill server. We should show the icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // Hidden fields are not treated differently.
   LoadHTMLWithUserGesture(kHiddenPasswordAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kHiddenPasswordAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // This doesn't trigger because the form action is invalid.
   LoadHTMLWithUserGesture(kInvalidActionAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kInvalidActionAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 }
 
 TEST_F(PasswordGenerationAgentTest, FillTest) {
   // Make sure that we are enabled before loading HTML.
   std::string html = std::string(kAccountCreationFormHTML) +
       ChangeDetectionScript;
   LoadHTMLWithUserGesture(html.c_str());
   SetNotBlacklistedMessage(password_generation_, html.c_str());
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
@@ skipping 94 matching lines @@
             password_generation_->messages()[1]->type());
 }
 
 TEST_F(PasswordGenerationAgentTest, BlacklistedTest) {
   // Did not receive not blacklisted message. Don't show password generation
   // icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 
   // Receive one not blacklisted message for non account creation form. Don't
   // show password generation icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kSigninFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 
   // Receive one not blacklisted message for account creation form. Show
   // password generation icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // Receive two not blacklisted messages, one is for account creation form and
   // the other is not. Show password generation icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kSigninFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, AccountCreationFormsDetectedTest) {
   // Did not receive account creation forms detected message. Don't show
   // password generation icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 
   // Receive the account creation forms detected message. Show password
   // generation icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
   base::HistogramTester histogram_tester;
 
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
 
   // Make a password just under maximum offer size.
   SimulateUserInputChangeForElement(
       &first_password_element,
@@ skipping 70 matching lines @@
 
   // This needs to come after the DOM has been modified.
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          1);
 
   // TODO(gcasto): I'm slightly worried about flakes in this test where
   // didAssociateFormControls() isn't called. If this turns out to be a problem
   // adding a call to OnDynamicFormsSeen(GetMainFrame()) will fix it, though
   // it will weaken the test.
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MultiplePasswordFormsTest) {
   // If two forms on the page looks like possible account creation forms, make
   // sure to trigger on the one that is specified from Autofill.
   LoadHTMLWithUserGesture(kMultipleAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kMultipleAccountCreationFormHTML);
 
   // Should trigger on the second form.
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          1);
 
-  ExpectPasswordGenerationAvailable("password", false);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("password", false);
+  ExpectGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MessagesAfterAccountSignupFormFound) {
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
 
   // Generation should be enabled.
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // Extra not blacklisted messages can be sent. Make sure that they are handled
   // correctly (generation should still be available).
   SetNotBlacklistedMessage(password_generation_, kAccountCreationFormHTML);
 
   // Need to focus another field first for verification to work.
-  ExpectPasswordGenerationAvailable("second_password", false);
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("second_password", false);
+  ExpectGenerationAvailable("first_password", true);
 }
 
 // Losing focus should not trigger a password generation popup.
 TEST_F(PasswordGenerationAgentTest, BlurTest) {
   LoadHTMLWithUserGesture(kDisabledElementAccountCreationFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kDisabledElementAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(),
                                          0);
 
   // Focus on the first password field: password generation popup should show
   // up.
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // Remove focus from everywhere by clicking an unfocusable element: password
   // generation popup should not show up.
   EXPECT_TRUE(SimulateElementClick("disabled"));
   EXPECT_EQ(0u, password_generation_->messages().size());
 }
 
 TEST_F(PasswordGenerationAgentTest, AutocompleteAttributesTest) {
   // Verify that autocomplete attributes can override Autofill to enable
   // generation
   LoadHTMLWithUserGesture(kBothAutocompleteAttributesFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kBothAutocompleteAttributesFormHTML);
 
-  ExpectPasswordGenerationAvailable("first_password", true);
+  ExpectGenerationAvailable("first_password", true);
 
   // Only setting one of the two attributes doesn't trigger generation.
   LoadHTMLWithUserGesture(kUsernameAutocompleteAttributeFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kUsernameAutocompleteAttributeFormHTML);
 
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 
   LoadHTMLWithUserGesture(kNewPasswordAutocompleteAttributeFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kNewPasswordAutocompleteAttributeFormHTML);
 
-  ExpectPasswordGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", false);
 }
 
 }  // namespace autofill