Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(64)

Issue 1184863003: Make ASAN happy in MHTMLTest.TestMHTMLEncoding (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ASAN happy in MHTMLTest.TestMHTMLEncoding SharedBuffer's valid memory ranges are annotated for ASAN. This means that the single-argument std::string ctor from char* will read past the end of the valid range when it scans for a terminating \0. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/tests/MHTMLTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
Random cleanup.
4 years, 10 months ago (2015-06-12 20:12:39 UTC) #2
Nate Chapin
lgtm
4 years, 10 months ago (2015-06-12 20:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184863003/1
4 years, 10 months ago (2015-06-12 20:18:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66497)
4 years, 10 months ago (2015-06-13 00:02:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184863003/1
4 years, 10 months ago (2015-06-15 20:43:34 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 23:43:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197147

Powered by Google App Engine
This is Rietveld 408576698