Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1184853003: Remove some unused definitions from d8.h (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove some unused definitions from d8.h BUG=none LOG=n Committed: https://crrev.com/9bda43a2ea8613eae5cd20ff0c28cd1a663d67d5 Cr-Commit-Position: refs/heads/master@{#29006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M src/d8.h View 4 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
binji
I noticed these while adding fake worker support.
5 years, 6 months ago (2015-06-12 18:52:50 UTC) #2
Jarin
drive-by lgtm.
5 years, 6 months ago (2015-06-12 19:02:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184853003/1
5 years, 6 months ago (2015-06-12 19:39:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 19:41:03 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 19:41:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bda43a2ea8613eae5cd20ff0c28cd1a663d67d5
Cr-Commit-Position: refs/heads/master@{#29006}

Powered by Google App Engine
This is Rietveld 408576698