fixes #192, encode dynamic info in checker

fixes #192, encode dynamic info in checker
fixes a checker bug too: it wasn't working properly for cascade targets. Previously this caught #202 and #206 as well.

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/b0e5afe5296dd4859ff3a7dfa7805cc5f884b852

[Jennifer Messerly, 2015-06-12 18:15:42]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Jennifer Messerly, 2015-06-12 18:18:09]

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
lib/src/checker/checker.dart:560: DynamicInvoke.set(node.methodName, true);
we are interesting both in whether the method call is dynamic, and whether the
tear off is.

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
lib/src/checker/checker.dart:632: var target = node.realTarget;
bug fix: cascade dinvoke not reported

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
lib/src/checker/checker.dart:842: var target = node.realTarget;
bug fix: cascade dinvoke not reported

https://codereview.chromium.org/1184843002/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1184843002/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:1990: DynamicInvoke.set(id, type.isDynamic);
this is the downside, it's one more bit to copy ...

[Leaf, 2015-06-12 20:13:23]

Nice!  lgtm.

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
lib/src/checker/checker.dart:560: DynamicInvoke.set(node.methodName, true);
On 2015/06/12 18:18:09, John Messerly wrote:
> we are interesting both in whether the method call is dynamic, and whether the
> tear off is.

This is a little obscure, maybe worth a bit more expansion in comments (maybe an
example)?

[Jennifer Messerly, 2015-06-12 20:22:28]

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/1184843002/diff/20001/lib/src/checker/checker...
lib/src/checker/checker.dart:560: DynamicInvoke.set(node.methodName, true);
On 2015/06/12 20:13:23, Leaf wrote:
> On 2015/06/12 18:18:09, John Messerly wrote:
> > we are interesting both in whether the method call is dynamic, and whether
the
> > tear off is.
> 
> This is a little obscure, maybe worth a bit more expansion in comments (maybe
an
> example)?

sure. will add. For your info, what happens is we generate:

dart.dcall(someDynamicThing.field, args);

... which is not correct. Should be:

dart.dsend(someDynamicThing, 'field', args);

[Jennifer Messerly, 2015-06-12 20:38:11]

comment added!

[Jennifer Messerly, 2015-06-12 20:39:48]

Committed patchset #3 (id:40001) manually as
b0e5afe5296dd4859ff3a7dfa7805cc5f884b852 (presubmit successful).