Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1184783004: Disable blink_perf.bindings. (Closed)

Created:
5 years, 6 months ago by shatch
Modified:
5 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable blink_perf.bindings. BUG=500958 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect; Committed: https://crrev.com/39568f19b87104614f20cad8588e335aa39cc555 Cr-Commit-Position: refs/heads/master@{#334876}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed (). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shatch
5 years, 6 months ago (2015-06-17 16:08:15 UTC) #2
nednguyen
lgtm
5 years, 6 months ago (2015-06-17 16:09:25 UTC) #4
nednguyen
https://codereview.chromium.org/1184783004/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/1184783004/diff/1/tools/perf/benchmarks/blink_perf.py#newcode140 tools/perf/benchmarks/blink_perf.py:140: @benchmark.Disabled() # http://crbug.com/500958 It looks to me that it ...
5 years, 6 months ago (2015-06-17 16:10:46 UTC) #6
shatch
https://codereview.chromium.org/1184783004/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/1184783004/diff/1/tools/perf/benchmarks/blink_perf.py#newcode140 tools/perf/benchmarks/blink_perf.py:140: @benchmark.Disabled() # http://crbug.com/500958 On 2015/06/17 16:10:46, nednguyen wrote: > ...
5 years, 6 months ago (2015-06-17 16:14:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184783004/20001
5 years, 6 months ago (2015-06-17 16:15:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 18:21:46 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 18:22:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39568f19b87104614f20cad8588e335aa39cc555
Cr-Commit-Position: refs/heads/master@{#334876}

Powered by Google App Engine
This is Rietveld 408576698