Implement enumerateDevices() according to spec.

Implement enumerateDevices() according to spec.

See http://w3c.github.io/mediacapture-main/getusermedia.html#enumerating-devices


BUG=388648
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197213

[Guido Urdaneta, 2015-06-12 18:22:12]

guidou@chromium.org changed reviewers:
+ grunell@google.com, hta@chromium.org, peter@chromium.org, tommi@chromium.org

[Guido Urdaneta, 2015-06-12 18:24:14]

guidou@chromium.org changed reviewers:
+ mkwst@chromium.org

[Guido Urdaneta, 2015-06-12 18:29:19]

Hi,

Please review.

[Mike West, 2015-06-15 08:10:54]

On 2015/06/12 at 18:29:19, guidou wrote:
> Hi,
> 
> Please review.

Same question as the other review; what is the permission model you're running
with?

[Guido Urdaneta, 2015-06-15 08:58:43]

On 2015/06/15 08:10:54, Mike West wrote:
> On 2015/06/12 at 18:29:19, guidou wrote:
> > Hi,
> > 
> > Please review.
> 
> Same question as the other review; what is the permission model you're running
> with?

Similar answer as the other :). 
The permission model is the mediastreams permissions model. This is what was
used by getMediaDevices() (not exposed to the Web) and
MediaStreamTrack.getSources() (exposed), which are obsolete ways to enumerate
devices. The way this is implemented in chromium is that if the user has granted
mediastream permissions, the enumeration will proceed. If not, the enumeration
still proceeds, but the returned values lack some of the information.

[Mike West, 2015-06-15 10:45:52]

On 2015/06/15 at 08:58:43, guidou wrote:
> On 2015/06/15 08:10:54, Mike West wrote:
> > On 2015/06/12 at 18:29:19, guidou wrote:
> > > Hi,
> > > 
> > > Please review.
> > 
> > Same question as the other review; what is the permission model you're
running
> > with?
> 
> Similar answer as the other :). 
> The permission model is the mediastreams permissions model. This is what was
used by getMediaDevices() (not exposed to the Web) and
MediaStreamTrack.getSources() (exposed), which are obsolete ways to enumerate
devices. The way this is implemented in chromium is that if the user has granted
mediastream permissions, the enumeration will proceed. If not, the enumeration
still proceeds, but the returned values lack some of the information.

Alright. LGTM, assuming this is going to go through privacy/security review
before launching to stable.

[Guido Urdaneta, 2015-06-15 10:59:54]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2015-06-15 11:00:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184743002/60001

[commit-bot: I haz the power, 2015-06-15 12:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 12:33:47]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Guido Urdaneta, 2015-06-15 14:20:03]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2015-06-15 14:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1184743002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-15 14:20:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184743002/80001

[commit-bot: I haz the power, 2015-06-15 16:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 16:14:24]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Guido Urdaneta, 2015-06-15 19:20:00]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2015-06-15 19:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184743002/80001

[commit-bot: I haz the power, 2015-06-15 21:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 21:15:19]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[Guido Urdaneta, 2015-06-17 00:31:15]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2015-06-17 00:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1184743002/#ps100001
(title: "Fix expected output of global interface listing test")

[commit-bot: I haz the power, 2015-06-17 00:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184743002/100001

[commit-bot: I haz the power, 2015-06-17 00:37:05]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197213

[Henrik Grunell, 2015-06-17 10:39:23]

grunell@chromium.org changed reviewers:
+ grunell@chromium.org

[Henrik Grunell, 2015-06-17 10:39:24]

Took a look after commit. lgtm

[Henrik Grunell, 2015-06-17 10:39:56]

grunell@chromium.org changed reviewers:
- grunell@google.com

[Peter Beverloo, 2015-06-18 14:28:50]

https://codereview.chromium.org/1184743002/diff/100001/LayoutTests/fast/media...
File LayoutTests/fast/mediastream/MediaDevices-enumerateDevices.html (right):

https://codereview.chromium.org/1184743002/diff/100001/LayoutTests/fast/media...
LayoutTests/fast/mediastream/MediaDevices-enumerateDevices.html:1: <!DOCTYPE
HTML PUBLIC "-//IETF//DTD HTML//EN">
nit: Please use

<!doctype html> (or <!DOCTYPE HTML>) as the doctype.

https://codereview.chromium.org/1184743002/diff/100001/Source/modules/mediast...
File Source/modules/mediastream/MediaDevicesRequest.cpp (right):

https://codereview.chromium.org/1184743002/diff/100001/Source/modules/mediast...
Source/modules/mediastream/MediaDevicesRequest.cpp:74: return
ScriptPromise::rejectWithDOMException(m_resolver->scriptState(),
DOMException::create(NotSupportedError, "No media device controller
available"));
I'd still like to know when this occurs (dito with the rejection in
MediaDevices::enumerateDevices()).

Especially this one feels like it should be an ASSERT() in our code rather than
Web exposed behavior. If I were a Web developer and I received this message,
what would I do with it?