Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118473006: Allow multiple concurrent timers. (Closed)

Created:
7 years ago by jcgregorio
Modified:
7 years ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Allow multiple concurrent timers. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12802

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M experimental/SkV8Example/Global.h View 1 5 chunks +11 lines, -2 lines 2 comments Download
M experimental/SkV8Example/Global.cpp View 1 5 chunks +26 lines, -17 lines 0 comments Download
M experimental/SkV8Example/SkV8Example.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/SkV8Example/sample.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcgregorio
7 years ago (2013-12-19 20:51:55 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/118473006/diff/20001/experimental/SkV8Example/Global.h File experimental/SkV8Example/Global.h (right): https://codereview.chromium.org/118473006/diff/20001/experimental/SkV8Example/Global.h#newcode12 experimental/SkV8Example/Global.h:12: I'm not sure if we want to start ...
7 years ago (2013-12-20 14:49:43 UTC) #2
jcgregorio
https://codereview.chromium.org/118473006/diff/20001/experimental/SkV8Example/Global.h File experimental/SkV8Example/Global.h (right): https://codereview.chromium.org/118473006/diff/20001/experimental/SkV8Example/Global.h#newcode12 experimental/SkV8Example/Global.h:12: On 2013/12/20 14:49:43, robertphillips wrote: > I'm not sure ...
7 years ago (2013-12-20 14:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/118473006/20001
7 years ago (2013-12-20 15:12:50 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-20 15:56:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 12802

Powered by Google App Engine
This is Rietveld 408576698