Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap-snapshot-generator-inl.h" 7 #include "src/heap-snapshot-generator-inl.h"
8 8
9 #include "src/allocation-tracker.h" 9 #include "src/allocation-tracker.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 1287
1288 1288
1289 void V8HeapExplorer::ExtractMapReferences(int entry, Map* map) { 1289 void V8HeapExplorer::ExtractMapReferences(int entry, Map* map) {
1290 Object* raw_transitions_or_prototype_info = map->raw_transitions(); 1290 Object* raw_transitions_or_prototype_info = map->raw_transitions();
1291 if (TransitionArray::IsFullTransitionArray( 1291 if (TransitionArray::IsFullTransitionArray(
1292 raw_transitions_or_prototype_info)) { 1292 raw_transitions_or_prototype_info)) {
1293 TransitionArray* transitions = 1293 TransitionArray* transitions =
1294 TransitionArray::cast(raw_transitions_or_prototype_info); 1294 TransitionArray::cast(raw_transitions_or_prototype_info);
1295 int transitions_entry = GetEntry(transitions)->index(); 1295 int transitions_entry = GetEntry(transitions)->index();
1296 1296
1297 if (FLAG_collect_maps && map->CanTransition()) { 1297 if (map->CanTransition()) {
1298 if (transitions->HasPrototypeTransitions()) { 1298 if (transitions->HasPrototypeTransitions()) {
1299 FixedArray* prototype_transitions = 1299 FixedArray* prototype_transitions =
1300 transitions->GetPrototypeTransitions(); 1300 transitions->GetPrototypeTransitions();
1301 MarkAsWeakContainer(prototype_transitions); 1301 MarkAsWeakContainer(prototype_transitions);
1302 TagObject(prototype_transitions, "(prototype transitions"); 1302 TagObject(prototype_transitions, "(prototype transitions");
1303 SetInternalReference(transitions, transitions_entry, 1303 SetInternalReference(transitions, transitions_entry,
1304 "prototype_transitions", prototype_transitions); 1304 "prototype_transitions", prototype_transitions);
1305 } 1305 }
1306 // TODO(alph): transitions keys are strong links. 1306 // TODO(alph): transitions keys are strong links.
1307 MarkAsWeakContainer(transitions); 1307 MarkAsWeakContainer(transitions);
(...skipping 1869 matching lines...) Expand 10 before | Expand all | Expand 10 after
3177 for (int i = 1; i < sorted_strings.length(); ++i) { 3177 for (int i = 1; i < sorted_strings.length(); ++i) {
3178 writer_->AddCharacter(','); 3178 writer_->AddCharacter(',');
3179 SerializeString(sorted_strings[i]); 3179 SerializeString(sorted_strings[i]);
3180 if (writer_->aborted()) return; 3180 if (writer_->aborted()) return;
3181 } 3181 }
3182 } 3182 }
3183 3183
3184 3184
3185 } // namespace internal 3185 } // namespace internal
3186 } // namespace v8 3186 } // namespace v8
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698