Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1184713005: Removing unused methods from FEComponentTransfer (Closed)

Created:
5 years, 6 months ago by tanay.c
Modified:
5 years, 6 months ago
Reviewers:
lgombos, Mike West
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused methods from FEComponentTransfer - setRedFunction() - setGreenFunction() - setBlueFunction() - setAlphaFunction() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tanay.c
PTAL
5 years, 6 months ago (2015-06-18 13:10:43 UTC) #1
tanay.c
PTAL
5 years, 6 months ago (2015-06-18 13:11:23 UTC) #3
Mike West
LGTM, assuming everything compiles.
5 years, 6 months ago (2015-06-18 14:54:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184713005/1
5 years, 6 months ago (2015-06-18 20:48:50 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 22:19:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197401

Powered by Google App Engine
This is Rietveld 408576698