Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1184713004: google_apis: Migrate callers of message_loop_proxy() to task_runner() (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

google_apis: Migrate callers of message_loop_proxy() to task_runner() Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 Committed: https://crrev.com/8c36b0c96bee3fea8e5b125bacae03d3c537a386 Cr-Commit-Position: refs/heads/master@{#334768}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/account_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_api_call_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/registration_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sami
5 years, 6 months ago (2015-06-12 17:25:49 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 6 months ago (2015-06-12 18:32:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184713004/1
5 years, 6 months ago (2015-06-16 22:59:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/35837) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-16 23:06:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184713004/20001
5 years, 6 months ago (2015-06-17 00:57:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 01:59:13 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 02:00:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c36b0c96bee3fea8e5b125bacae03d3c537a386
Cr-Commit-Position: refs/heads/master@{#334768}

Powered by Google App Engine
This is Rietveld 408576698