Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
Help
|
Chromium Project
|
Gerrit Changes
|
Sign in
(102)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
1184693003
: Revert 196987 "Don't invoke default actions for MouseEvents gene..." (Closed)
Created:
4 years, 10 months ago by
haraken
Modified:
4 years, 10 months ago
Reviewers:
kirkshoop_msft
CC:
blink-reviews
Base URL:
svn://svn.chromium.org/blink/
Visibility:
Public.
More Reviews
Description
Revert 196987 "Don't invoke default actions for MouseEvents gene..." content_browsertets's DumpAccessibilityEventsTest.AccessibilityEventsMenuListPopup is failing on win platforms. > Don't invoke default actions for MouseEvents generated by script (other than "click") > > Brings blink in-line with the DOM events spec and behavior of IE and Firefox. > > BUG=
423975
>
R=rbyers@chromium.org
> > Review URL:
https://codereview.chromium.org/894913002
TBR=kirk.shoop@microsoft.com
Committed:
https://src.chromium.org/viewvc/blink?view=rev&revision=197020
Patch Set 1
#
Created:
4 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+71 lines, -142 lines
)
Patch
MM
trunk/LayoutTests/fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash.html
View
1 chunk
+5 lines, -9 lines
0 comments
Download
MM
trunk/LayoutTests/fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash-expected.txt
View
1 chunk
+1 line, -2 lines
0 comments
Download
D
trunk/LayoutTests/fast/events/dispatch-synthetic-mouseevent-no-action.html
View
1 chunk
+0 lines, -32 lines
0 comments
Download
D
trunk/LayoutTests/fast/events/dispatch-synthetic-mouseevent-no-action-expected.txt
View
1 chunk
+0 lines, -11 lines
0 comments
Download
M
trunk/LayoutTests/fast/forms/listbox-onchange.html
View
2 chunks
+15 lines, -27 lines
0 comments
Download
M
trunk/LayoutTests/fast/forms/range/slider-transformed.html
View
1 chunk
+10 lines, -4 lines
0 comments
Download
MM
trunk/LayoutTests/fast/forms/range/slider-zoomed.html
View
1 chunk
+10 lines, -5 lines
0 comments
Download
MM
trunk/LayoutTests/fast/forms/select-list-box-mouse-focus.html
View
2 chunks
+7 lines, -13 lines
0 comments
Download
MM
trunk/LayoutTests/fast/forms/select-list-box-mouse-focus-expected.txt
View
1 chunk
+2 lines, -2 lines
0 comments
Download
M
trunk/LayoutTests/plugins/user-gesture.html
View
1 chunk
+1 line, -1 line
0 comments
Download
M
trunk/LayoutTests/plugins/user-gesture-expected.txt
View
1 chunk
+5 lines, -1 line
0 comments
Download
M
trunk/Source/core/dom/Node.h
View
3 chunks
+0 lines, -3 lines
0 comments
Download
M
trunk/Source/core/dom/Node.cpp
View
2 chunks
+2 lines, -9 lines
0 comments
Download
M
trunk/Source/core/events/EventDispatcher.cpp
View
1 chunk
+1 line, -7 lines
0 comments
Download
M
trunk/Source/core/events/MouseEvent.h
View
2 chunks
+5 lines, -5 lines
0 comments
Download
M
trunk/Source/core/events/MouseEvent.cpp
View
4 chunks
+6 lines, -7 lines
0 comments
Download
M
trunk/Source/core/input/EventHandler.cpp
View
1 chunk
+1 line, -2 lines
0 comments
Download
M
trunk/Source/platform/PlatformMouseEvent.h
View
1 chunk
+0 lines, -2 lines
0 comments
Download
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
haraken
4 years, 10 months ago (2015-06-12 09:04:55 UTC)
#1
haraken
Committed patchset #1 (id:1) manually as r197020.
4 years, 10 months ago (2015-06-12 09:05:12 UTC)
#2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r197020.
Expand Messages
|
Collapse Messages
Issue 1184693003: Revert 196987 "Don't invoke default actions for MouseEvents gene..." (Closed)
Created 4 years, 10 months ago by haraken
Modified 4 years, 10 months ago
Reviewers: kirkshoop_msft
Base URL: svn://svn.chromium.org/blink/
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
