Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issue 118469: compile on openbsd: mostly ifdefs and missing includes,... (Closed)

Created:
10 years, 8 months ago by pvalchev
Modified:
8 years, 9 months ago
Reviewers:
tony, evanm
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

compile on openbsd: mostly ifdefs and missing includes, a few small changes but all ifdef'ed to openbsd

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -31 lines) Patch
M base/clipboard.h View 2 chunks +2 lines, -2 lines 1 comment Download
M base/clipboard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/clipboard_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/crypto/signature_verifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_version_info.h View 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/native_widget_types.h View 5 chunks +6 lines, -6 lines 0 comments Download
M base/gfx/rect.h View 4 chunks +4 lines, -4 lines 0 comments Download
M base/logging.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/native_library.h View 1 chunk +1 line, -1 line 0 comments Download
M base/path_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/platform_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_thread_posix.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/process_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/test_suite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/third_party/nspr/prcpucfg.h View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/nspr/prtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M build/build_config.h View 2 chunks +7 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
pvalchev
These are most of the changes for compiling src/base_unittest on OpenBSD. As FYI I'll have ...
10 years, 8 months ago (2009-06-09 23:20:27 UTC) #1
tony
Evan is on vacation this week so I'm taking this. http://codereview.chromium.org/118469/diff/1032/1045 File base/clipboard.h (right): http://codereview.chromium.org/118469/diff/1032/1045#newcode24 ...
10 years, 8 months ago (2009-06-10 18:42:04 UTC) #2
pvalchev
Thanks Tony, I was wondering about the cleanliness of the defines and other BSD's too ...
10 years, 8 months ago (2009-06-11 23:15:22 UTC) #3
tony
Yes, that's right. I imagine all will define OS_BSD and each will also define one ...
10 years, 8 months ago (2009-06-11 23:20:25 UTC) #4
pvalchev_sightly.net
I had started to clean it up with OS_BSD defines but then disappeared, trying to ...
10 years, 5 months ago (2009-09-03 23:19:34 UTC) #5
tony
On 2009/09/03 23:19:34, pvalchev_sightly.net wrote: > I had started to clean it up with OS_BSD ...
10 years, 5 months ago (2009-09-03 23:24:29 UTC) #6
pvalchev_sightly.net
10 years, 5 months ago (2009-09-04 16:25:47 UTC) #7
On Fri, Sep 4, 2009 at 3:06 AM, Ben Laurie<benl@chromium.org> wrote:
> On Fri, Sep 4, 2009 at 12:09 AM, <pvalchev@gmail.com> wrote:
>> Nice!
>>
>> So I had started a very similar patch for OpenBSD:
>> http://codereview.chromium.org/118469
>>
>> But I got really busy shortly after and went on vacation, I'd like to
>> resume & merge my patch too. The reason I didn't finish it is because I
>> wanted to clean it up and make a OS_BSD define like discussed in that
>> patch with tony@, matching all of the BSD's. Any chance we can do this?
>> I see you are adding OS_FREEBSD || OS_LINUX one-offs everywhere and the
>> same will have to be repeated for all of the BSD's... it would be nice
>> to make this cleaner.
>
> Sure, I'd be happy to go down this route. Presumably you'd still want
> there to be an OS_FREEBSD and OS_OPENBSD as well, for the, presumably
> few, places where they differ?

Great! And yeah, exactly, that's what I have in my tree:

So in build_config.h:
+#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__NetBSD__)
+#define OS_BSD 1
+#endif

then for each individual one define OS_FREEBSD etc... too, as i'm sure
there'll be differences we need to account for.

Powered by Google App Engine
This is Rietveld 408576698