Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1184673006: When --mpd is true, run _mpd variants first, then non-mpd. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

When --mpd is true, run _mpd variants first, then non-mpd. This makes it easier to benchmark _mpd variants in a profiler. E.g., <profiler> out/Release/nanobench --images --config 8888 --loops -1 --match sp_desk_nytimes BUG=skia: Committed: https://skia.googlesource.com/skia/+/c751ecb3681072fda53dd3cebeb2eb41fc73b314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-15 15:49:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184673006/1
5 years, 6 months ago (2015-06-15 15:49:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 15:54:14 UTC) #6
herb_g
lgtm
5 years, 6 months ago (2015-06-15 15:55:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184673006/1
5 years, 6 months ago (2015-06-15 15:56:12 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 15:56:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c751ecb3681072fda53dd3cebeb2eb41fc73b314

Powered by Google App Engine
This is Rietveld 408576698