Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: Source/platform/text/UnicodeUtilitiesTest.cpp

Issue 1184673003: Fix unit test style in Source/platform/, part 2. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/text/UnicodeUtilitiesTest.cpp
diff --git a/Source/platform/text/UnicodeUtilitiesTest.cpp b/Source/platform/text/UnicodeUtilitiesTest.cpp
index 4014269173d398928a94999de4ff3747e6ff42c4..abcf20d73fae6fced1aaf03950aca566bb863419 100644
--- a/Source/platform/text/UnicodeUtilitiesTest.cpp
+++ b/Source/platform/text/UnicodeUtilitiesTest.cpp
@@ -37,9 +37,7 @@
#include <gtest/gtest.h>
#include <unicode/uchar.h>
-using namespace blink;
-
-namespace {
+namespace blink {
static const UChar32 kMaxLatinCharCount = 256;
@@ -58,7 +56,7 @@ UBool U_CALLCONV testFirstAndLastCharsInCategory(const void *context, UChar32 st
return 1;
}
-TEST(WebCoreUnicodeUnit, Separators)
+TEST(UnicodeUtilitiesTest, Separators)
{
static const bool latinSeparatorTable[kMaxLatinCharCount] = {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
@@ -88,7 +86,7 @@ TEST(WebCoreUnicodeUnit, Separators)
EXPECT_FALSE(isTestFirstAndLastCharsInCategoryFailed);
}
-TEST(WebCoreUnicodeUnit, KanaLetters)
+TEST(UnicodeUtilitiesTest, KanaLetters)
{
// Non Kana symbols
for (UChar character = 0; character < 0x3041; ++character)
@@ -103,7 +101,7 @@ TEST(WebCoreUnicodeUnit, KanaLetters)
EXPECT_TRUE(isKanaLetter(character));
}
-TEST(WebCoreUnicodeUnit, ContainsKanaLetters)
+TEST(UnicodeUtilitiesTest, ContainsKanaLetters)
{
// Non Kana symbols
String nonKanaString;
@@ -126,7 +124,7 @@ TEST(WebCoreUnicodeUnit, ContainsKanaLetters)
}
}
-TEST(WebCoreUnicodeUnit, FoldQuoteMarkOrSoftHyphenTest)
+TEST(UnicodeUtilitiesTest, FoldQuoteMarkOrSoftHyphenTest)
{
const UChar charactersToFold[] = {
hebrewPunctuationGershayimCharacter, leftDoubleQuotationMarkCharacter, rightDoubleQuotationMarkCharacter,
@@ -147,7 +145,7 @@ TEST(WebCoreUnicodeUnit, FoldQuoteMarkOrSoftHyphenTest)
EXPECT_EQ(String(buffer), foldedString);
}
-TEST(WebCoreUnicodeUnit, OnlyKanaLettersEqualityTest)
+TEST(UnicodeUtilitiesTest, OnlyKanaLettersEqualityTest)
{
const UChar nonKanaString1[] = { 'a', 'b', 'c', 'd' };
const UChar nonKanaString2[] = { 'e', 'f', 'g' };
@@ -187,7 +185,7 @@ TEST(WebCoreUnicodeUnit, OnlyKanaLettersEqualityTest)
voicedKanaString2, WTF_ARRAY_LENGTH(voicedKanaString2)));
}
-TEST(WebCoreUnicodeUnit, StringsWithKanaLettersTest)
+TEST(UnicodeUtilitiesTest, StringsWithKanaLettersTest)
{
const UChar nonKanaString1[] = { 'a', 'b', 'c' };
const UChar nonKanaString2[] = { 'a', 'b', 'c' };
@@ -245,4 +243,4 @@ TEST(WebCoreUnicodeUnit, StringsWithKanaLettersTest)
voicedKanaString2, WTF_ARRAY_LENGTH(voicedKanaString2)));
}
-} // namespace
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698