Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: Source/platform/graphics/ImageDecodingStoreTest.cpp

Issue 1184673003: Fix unit test style in Source/platform/, part 2. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/ImageDecodingStoreTest.cpp
diff --git a/Source/platform/graphics/ImageDecodingStoreTest.cpp b/Source/platform/graphics/ImageDecodingStoreTest.cpp
index f4695edf9df2de6d053622299181d28189306989..ca3edaa324fd6b7ceaddf86166e5613356130204 100644
--- a/Source/platform/graphics/ImageDecodingStoreTest.cpp
+++ b/Source/platform/graphics/ImageDecodingStoreTest.cpp
@@ -24,7 +24,6 @@
*/
#include "config.h"
-
#include "platform/graphics/ImageDecodingStore.h"
#include "platform/SharedBuffer.h"
@@ -32,13 +31,11 @@
#include "platform/graphics/test/MockImageDecoder.h"
#include <gtest/gtest.h>
-using namespace blink;
-
-namespace {
+namespace blink {
class ImageDecodingStoreTest : public ::testing::Test, public MockImageDecoderClient {
public:
- virtual void SetUp()
+ void SetUp() override
{
ImageDecodingStore::instance().setCacheLimitInBytes(1024 * 1024);
m_data = SharedBuffer::create();
@@ -46,30 +43,30 @@ public:
m_decodersDestroyed = 0;
}
- virtual void TearDown()
+ void TearDown() override
{
ImageDecodingStore::instance().clear();
}
- virtual void decoderBeingDestroyed()
+ void decoderBeingDestroyed() override
{
++m_decodersDestroyed;
}
- virtual void decodeRequested()
+ void decodeRequested() override
{
// Decoder is never used by ImageDecodingStore.
ASSERT_TRUE(false);
}
- virtual ImageFrame::Status status()
+ ImageFrame::Status status() override
{
return ImageFrame::FramePartial;
}
- virtual size_t frameCount() { return 1; }
- virtual int repetitionCount() const { return cAnimationNone; }
- virtual float frameDuration() const { return 0; }
+ size_t frameCount() override { return 1; }
+ int repetitionCount() const override { return cAnimationNone; }
+ float frameDuration() const override { return 0; }
protected:
void evictOneCache()
@@ -179,4 +176,4 @@ TEST_F(ImageDecodingStoreTest, removeDecoder)
EXPECT_FALSE(ImageDecodingStore::instance().lockDecoder(m_generator.get(), size, &testDecoder));
}
-} // namespace
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698