Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1184673003: Fix unit test style in Source/platform/, part 2. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-layers+watch_chromium.org, krit, vikasa, Rik, urvang, jzern, dshwang, skal, jbroman, Justin Novosad, leviw+bidiwatch_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, scheduler-bugs_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unit test style in Source/platform/, part 2. Mainly fix namespace usage. This CL has no behavior changes. BUG=498604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197001

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -388 lines) Patch
M Source/platform/graphics/Canvas2DLayerBridge.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 6 chunks +10 lines, -13 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerManager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerManagerTest.cpp View 10 chunks +11 lines, -14 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 6 chunks +28 lines, -28 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStoreTest.cpp View 4 chunks +10 lines, -13 lines 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 6 chunks +13 lines, -15 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 2 chunks +2 lines, -2 lines 3 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 7 chunks +10 lines, -14 lines 0 comments Download
M Source/platform/graphics/ThreadSafeDataTransportTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FilterOperationsTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 7 chunks +11 lines, -14 lines 0 comments Download
M Source/platform/image-decoders/ImageDecoderTest.cpp View 5 chunks +6 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/platform/network/FormDataTest.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/platform/scroll/ScrollableAreaTest.cpp View 4 chunks +11 lines, -14 lines 0 comments Download
M Source/platform/text/BidiResolverTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/text/DateTimeFormatTest.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M Source/platform/text/LocaleICUTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/platform/text/LocaleMacTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/platform/text/LocaleWinTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/text/SegmentedStringTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/text/UnicodeUtilitiesTest.cpp View 8 chunks +8 lines, -10 lines 0 comments Download
M Source/platform/transforms/TransformOperationsTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/transforms/TransformationMatrixTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/weborigin/DatabaseIdentifierTest.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/platform/weborigin/KURLTest.cpp View 26 chunks +75 lines, -79 lines 0 comments Download
M Source/platform/weborigin/KnownPortsTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/weborigin/OriginAccessEntryTest.cpp View 16 chunks +19 lines, -22 lines 0 comments Download
M Source/platform/weborigin/SecurityOriginTest.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicyTest.cpp View 3 chunks +47 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tkent
kochi-san, would you review this please?
4 years, 10 months ago (2015-06-12 05:14:57 UTC) #2
kochi
lgtm https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/RecordingImageBufferSurface.h File Source/platform/graphics/RecordingImageBufferSurface.h (right): https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/RecordingImageBufferSurface.h#newcode65 Source/platform/graphics/RecordingImageBufferSurface.h:65: friend class RecordingImageBufferSurfaceTest; // for unit testing nit: ...
4 years, 10 months ago (2015-06-12 05:35:54 UTC) #3
tkent
https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/RecordingImageBufferSurface.h File Source/platform/graphics/RecordingImageBufferSurface.h (right): https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/RecordingImageBufferSurface.h#newcode65 Source/platform/graphics/RecordingImageBufferSurface.h:65: friend class RecordingImageBufferSurfaceTest; // for unit testing On 2015/06/12 ...
4 years, 10 months ago (2015-06-12 05:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184673003/1
4 years, 10 months ago (2015-06-12 05:47:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197001
4 years, 10 months ago (2015-06-12 05:51:10 UTC) #7
kochi
4 years, 10 months ago (2015-06-12 05:54:27 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/Re...
File Source/platform/graphics/RecordingImageBufferSurface.h (right):

https://codereview.chromium.org/1184673003/diff/1/Source/platform/graphics/Re...
Source/platform/graphics/RecordingImageBufferSurface.h:65: friend class
RecordingImageBufferSurfaceTest; // for unit testing
On 2015/06/12 05:46:49, tkent wrote:
> On 2015/06/12 05:35:54, Takayoshi Kochi wrote:
> > nit: add // TODO(tkent): Use FRIEND_TEST macro provided by gtest_prod.h
> > ?
> 
> In this case, gtest_prod.h and base/gtest_prod_util.h won't help.  They are
> helpful for test case functions, not test fixture classes. 
> RecordingImageBufferSurfaceTest is a test fixture.
> 

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698