Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1184613004: Revert 196997 "Oilpan: Defer reusing freed memory for one GC cycle" (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 196997 "Oilpan: Defer reusing freed memory for one GC cycle" This broke ASan builds. > Oilpan: Defer reusing freed memory for one GC cycle > > This CL defers reusing freed memory for (at least) one GC cycle or coalescing. This is helpful to detect use-after-free errors caused by lazy sweeping (it is scary!). > > Before this CL, the deferment is enabled only on ASan builds. This CL enables the deferment in non-production builds (i.e., ASSERT || LSan || ASan). > > See the comment in addToFreeList() for how the deferment is implemented. > > BUG=420515 > > Review URL: https://codereview.chromium.org/1176003002 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -118 lines) Patch
M trunk/Source/platform/heap/Heap.h View 4 chunks +36 lines, -16 lines 0 comments Download
M trunk/Source/platform/heap/Heap.cpp View 4 chunks +27 lines, -60 lines 0 comments Download
M trunk/Source/platform/heap/HeapTest.cpp View 2 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
4 years, 10 months ago (2015-06-12 08:48:37 UTC) #1
haraken
4 years, 10 months ago (2015-06-12 08:48:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r197019.

Powered by Google App Engine
This is Rietveld 408576698