Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 1184613002: [Android] Remove search feature from enhanced bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
index 6241792733f60b04f1c399d55f254c537ad2b38b..f551a58b970ef0b4eb7d190d6de2f9256ae1c55a 100644
--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
@@ -80,17 +80,10 @@ EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv* env,
cluster_service_->AddObserver(this);
bookmark_image_service_ = static_cast<BookmarkImageServiceAndroid*>(
BookmarkImageServiceFactory::GetForBrowserContext(profile_));
- search_service_.reset(new BookmarkServerSearchService(
- profile_->GetRequestContext(),
- ProfileOAuth2TokenServiceFactory::GetForProfile(profile_),
- SigninManagerFactory::GetForProfile(profile_),
- EnhancedBookmarkModelFactory::GetForBrowserContext(profile_)));
- search_service_->AddObserver(this);
}
EnhancedBookmarksBridge::~EnhancedBookmarksBridge() {
cluster_service_->RemoveObserver(this);
- search_service_->RemoveObserver(this);
}
void EnhancedBookmarksBridge::Destroy(JNIEnv*, jobject) {
@@ -261,35 +254,6 @@ ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddBookmark(
return new_java_obj;
}
-void EnhancedBookmarksBridge::SendSearchRequest(JNIEnv* env,
- jobject obj,
- jstring j_query) {
- search_service_->Search(base::android::ConvertJavaStringToUTF8(env, j_query));
-}
-
-ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::GetSearchResults(
- JNIEnv* env,
- jobject obj,
- jstring j_query) {
- DCHECK(enhanced_bookmark_model_->loaded());
-
- ScopedJavaLocalRef<jobject> j_list =
- Java_EnhancedBookmarksBridge_createBookmarkIdList(env);
- scoped_ptr<std::vector<const BookmarkNode*>> results =
- search_service_->ResultForQuery(
- base::android::ConvertJavaStringToUTF8(env, j_query));
-
- // If result is null, return a null java reference.
- if (!results.get())
- return ScopedJavaLocalRef<jobject>();
-
- for (const BookmarkNode* node : *results) {
- Java_EnhancedBookmarksBridge_addToBookmarkIdList(env, j_list.obj(),
- node->id(), node->type());
- }
- return j_list;
-}
-
void EnhancedBookmarksBridge::OnChange(BookmarkServerService* service) {
DCHECK(enhanced_bookmark_model_->loaded());
JNIEnv* env = AttachCurrentThread();
@@ -300,8 +264,6 @@ void EnhancedBookmarksBridge::OnChange(BookmarkServerService* service) {
if (service == cluster_service_) {
Java_EnhancedBookmarksBridge_onFiltersChanged(env, obj.obj());
- } else if (service == search_service_.get()) {
- Java_EnhancedBookmarksBridge_onSearchResultReturned(env, obj.obj());
}
}

Powered by Google App Engine
This is Rietveld 408576698