Issue 1184603002: bindings: Use hidden value instead of ForceSet() in V8MessageEventCustom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1184603002: bindings: Use hidden value instead of ForceSet() in V8MessageEventCustom (Closed)

Created:
4 years, 10 months ago by bashi

Modified:
4 years, 10 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

bindings: Use hidden value instead of ForceSet() in V8MessageEventCustom ForceSet() is used to cache the result of MessageEvent.data but we want to remove ForceSet() so use hidden value instead. BUG=475206 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196998

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	Source/bindings/core/v8/custom/V8MessageEventCustom.cpp	View		2 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184603002/1

4 years, 10 months ago (2015-06-12 03:45:02 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-12 04:53:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196998

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages