Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: Source/core/layout/LayoutBox.cpp

Issue 1184563002: Fix broken preferred widths optimization involving subtree layout roots (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove the code! Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/layout/nested-subtree-layout-preferred-widths-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBox.cpp
diff --git a/Source/core/layout/LayoutBox.cpp b/Source/core/layout/LayoutBox.cpp
index a73c9fa68a333709f851161cef7003549fd8c997..8a34c30dccc7a58dc3d8f4122b9bdc57ed093c72 100644
--- a/Source/core/layout/LayoutBox.cpp
+++ b/Source/core/layout/LayoutBox.cpp
@@ -1946,10 +1946,6 @@ void LayoutBox::computeLogicalWidth(LogicalExtentComputedValues& computedValues)
return;
}
- // If layout is limited to a subtree, the subtree root's logical width does not change.
- if (node() && view()->frameView() && view()->frameView()->isLayoutRoot(*this))
- return;
-
// The parent box is flexing us, so it has increased or decreased our
// width. Use the width from the style context.
// FIXME: Account for writing-mode in flexible boxes.
« no previous file with comments | « LayoutTests/fast/layout/nested-subtree-layout-preferred-widths-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698