Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1184543002: Revert of Fix html_viewer build after latest blink roll (Closed)

Created:
5 years, 6 months ago by dcheng
Modified:
5 years, 6 months ago
CC:
chromium-reviews, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix html_viewer build after latest blink roll (patchset #1 id:1 of https://codereview.chromium.org/1164963002/) Reason for revert: Reland to unblock Blink patch for swapping frames. Original issue's description: > Fix html_viewer build after latest blink roll > > TBR=sky@chromium.org > BUG= > > Committed: https://crrev.com/927e7e577a0f9680f008971624a58809f25068b2 > Cr-Commit-Position: refs/heads/master@{#332728} TBR=sky@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/28fcf1477d5a5928d9e43e8f87f762693f722739 Cr-Commit-Position: refs/heads/master@{#334126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/html_viewer/html_document.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
dcheng
Created Revert of Fix html_viewer build after latest blink roll
5 years, 6 months ago (2015-06-11 22:31:35 UTC) #1
dcheng
Any objections? I did a full GN build locally with this revert and didn't see ...
5 years, 6 months ago (2015-06-11 22:32:50 UTC) #2
sky
Did you try windows? LGTM assuming it all works.
5 years, 6 months ago (2015-06-11 22:36:37 UTC) #3
dcheng
I only tried Linux. I'll try Windows too. GN works to build mandoline on Windows ...
5 years, 6 months ago (2015-06-11 22:44:10 UTC) #4
sky
That's right. And unfortunately there is no windows gn try bot. -Scott On Thu, Jun ...
5 years, 6 months ago (2015-06-11 22:49:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184543002/1
5 years, 6 months ago (2015-06-11 23:01:42 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 23:03:26 UTC) #9
dcheng
The Win GN build seems fine too, so I'm going to try relanding this.
5 years, 6 months ago (2015-06-12 04:17:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184543002/1
5 years, 6 months ago (2015-06-12 04:17:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 04:18:26 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 04:19:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28fcf1477d5a5928d9e43e8f87f762693f722739
Cr-Commit-Position: refs/heads/master@{#334126}

Powered by Google App Engine
This is Rietveld 408576698