Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 1184503003: IndexedDB: Array-type keypaths should not be returned as DOMStringLists (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/storage/indexeddb/resources/keypath-arrays.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/Source/bindings/modules/v8/V8BindingForModules.cpp b/Source/bindings/modules/v8/V8BindingForModules.cpp
index a7740e496db1325c67fd45b0d5699eda8500167d..3c5d6adee37ca0bbe4e34ac251f7b20fcf225534 100644
--- a/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -69,10 +69,7 @@ v8::Local<v8::Value> toV8(const IDBKeyPath& value, v8::Local<v8::Object> creatio
case IDBKeyPath::StringType:
return v8String(isolate, value.string());
case IDBKeyPath::ArrayType:
- RefPtrWillBeRawPtr<DOMStringList> keyPaths = DOMStringList::create();
- for (Vector<String>::const_iterator it = value.array().begin(); it != value.array().end(); ++it)
- keyPaths->append(*it);
- return toV8(keyPaths.release(), creationContext, isolate);
+ return toV8(value.array(), creationContext, isolate);
}
ASSERT_NOT_REACHED();
return v8::Undefined(isolate);
« no previous file with comments | « LayoutTests/storage/indexeddb/resources/keypath-arrays.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698